Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/860 update deprecated lifecycle methods #1430

Merged
merged 5 commits into from
Apr 27, 2020
Merged

Enhancement/860 update deprecated lifecycle methods #1430

merged 5 commits into from
Apr 27, 2020

Conversation

jqlee85
Copy link
Contributor

@jqlee85 jqlee85 commented Apr 23, 2020

Summary

Addresses issue #860

Relevant technical choices

Changes use of componentWillMount to componentDidMount in DashboardWinsAlerts component and updates storybook and webpack-bundle-analyzer packages that were using deprecated methods.

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@jqlee85 jqlee85 linked an issue Apr 23, 2020 that may be closed by this pull request
Update use of deprecated React lifecycle methods #860
Closed
aaemnnosttv
aaemnnosttv approved these changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felixarntz felixarntz merged commit 51eeddc into develop Apr 27, 2020
@felixarntz felixarntz deleted the enhancement/860-update-deprecated-lifecycle-methods branch April 27, 2020 20:01
@aaemnnosttv aaemnnosttv mentioned this pull request May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@aaemnnosttv aaemnnosttv aaemnnosttv approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update use of deprecated React lifecycle methods
4 participants
@jqlee85 @aaemnnosttv @felixarntz @googlebot