Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis to GitHub Actions #460

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

iinozemtsev
Copy link
Collaborator

It seems that the last completed Travis build was 6 days ago, and
travis-ci.org is going to be shut down anyway.

As with travis, api_benchmark/query_benchmark have a single stage
which generates protos checks format and runs analyzer.

For protobuf and protoc_plugin I've split a single format_analyze_test
stage into three separate stages for a better control of OSes and Dart
SDK versions.

protobuf tests run on windows, linux, and osx, but protoc_plugin
tests run on linux only (we'd need a way to make make protos work on
osx and windows to enable tests).

Fixes #459

@google-cla google-cla bot added the cla: yes label Jan 27, 2021
@iinozemtsev iinozemtsev requested review from sigurdm and kevmoo January 27, 2021 13:48
@iinozemtsev iinozemtsev force-pushed the migrate_github_actions branch 2 times, most recently from 2663e42 to a8189c8 Compare January 27, 2021 13:51
@iinozemtsev
Copy link
Collaborator Author

Sample green run from my fork: https://github.com/iinozemtsev/protobuf/runs/1777185442

@iinozemtsev iinozemtsev mentioned this pull request Jan 27, 2021
It seems that the last completed Travis build was 6 days ago, and
travis-ci.org is going to be shut down anyway.

As with travis, api_benchmark/query_benchmark have a single stage
which generates protos checks format and runs analyzer.

For protobuf and protoc_plugin I've split a single format_analyze_test
stage into three separate stages for a better control of OSes and Dart
SDK versions.

`protobuf` tests run on windows, linux, and osx, but `protoc_plugin`
tests run on linux only (we'd need a way to make `make protos` work on
osx and windows to enable tests).

Currently the pipeline takes about 16-17 minutes to run, mostly
because `make protos` for protoc_plugin takes around 2 minutes and
dartfmt check is slow (also around 2 minutes) for protoc_plugin and
query_benchmark. If this is an issue, we can potentially speed it by 4
minutes by merging all protoc_plugin stages into one (as tests run on
a single os anyway).

Fixes google#459
@iinozemtsev iinozemtsev force-pushed the migrate_github_actions branch from a8189c8 to afdd594 Compare January 27, 2021 14:49
@kevmoo kevmoo requested review from jonasfj and mit-mit January 28, 2021 06:05
Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
LGTM

@iinozemtsev iinozemtsev merged commit f3a64af into google:master Jan 28, 2021
@iinozemtsev iinozemtsev deleted the migrate_github_actions branch January 28, 2021 13:42
iinozemtsev added a commit to iinozemtsev/protobuf that referenced this pull request Jan 28, 2021
It seems that the last completed Travis build was 6 days ago, and
travis-ci.org is going to be shut down anyway.

As with travis, api_benchmark/query_benchmark have a single stage
which generates protos checks format and runs analyzer.

For protobuf and protoc_plugin I've split a single format_analyze_test
stage into three separate stages for a better control of OSes and Dart
SDK versions.

`protobuf` tests run on windows, linux, and osx, but `protoc_plugin`
tests run on linux only (we'd need a way to make `make protos` work on
osx and windows to enable tests).

Currently the pipeline takes about 16-17 minutes to run, mostly
because `make protos` for protoc_plugin takes around 2 minutes and
dartfmt check is slow (also around 2 minutes) for protoc_plugin and
query_benchmark. If this is an issue, we can potentially speed it by 4
minutes by merging all protoc_plugin stages into one (as tests run on
a single os anyway).

Fixes google#459
iinozemtsev added a commit to iinozemtsev/protobuf that referenced this pull request Jan 28, 2021
It seems that the last completed Travis build was 6 days ago, and
travis-ci.org is going to be shut down anyway.

As with travis, api_benchmark/query_benchmark have a single stage
which generates protos checks format and runs analyzer.

For protobuf and protoc_plugin I've split a single format_analyze_test
stage into three separate stages for a better control of OSes and Dart
SDK versions.

`protobuf` tests run on windows, linux, and osx, but `protoc_plugin`
tests run on linux only (we'd need a way to make `make protos` work on
osx and windows to enable tests).

Currently the pipeline takes about 16-17 minutes to run, mostly
because `make protos` for protoc_plugin takes around 2 minutes and
dartfmt check is slow (also around 2 minutes) for protoc_plugin and
query_benchmark. If this is an issue, we can potentially speed it by 4
minutes by merging all protoc_plugin stages into one (as tests run on
a single os anyway).

Fixes google#459
iinozemtsev added a commit to iinozemtsev/protobuf that referenced this pull request Jan 28, 2021
It seems that the last completed Travis build was 6 days ago, and
travis-ci.org is going to be shut down anyway.

As with travis, api_benchmark/query_benchmark have a single stage
which generates protos checks format and runs analyzer.

For protobuf and protoc_plugin I've split a single format_analyze_test
stage into three separate stages for a better control of OSes and Dart
SDK versions.

`protobuf` tests run on windows, linux, and osx, but `protoc_plugin`
tests run on linux only (we'd need a way to make `make protos` work on
osx and windows to enable tests).

Currently the pipeline takes about 16-17 minutes to run, mostly
because `make protos` for protoc_plugin takes around 2 minutes and
dartfmt check is slow (also around 2 minutes) for protoc_plugin and
query_benchmark. If this is an issue, we can potentially speed it by 4
minutes by merging all protoc_plugin stages into one (as tests run on
a single os anyway).

Fixes google#459
iinozemtsev added a commit that referenced this pull request Jan 29, 2021
This brings the following changes from master branch:

- Support optional proto3 fields (#444)
- Fix handling of oneofs in dart proto3 json parsing. (#447)
- Use @Dart = 2.7 in generated files (#455)
- Migrate from Travis to GitHub Actions (#460)
- Emit binary coded descriptors from dart protoc_plugin. (#406)

Github Actions config modified to run only on dev sdk. Also modify analyzer flags to remove --fatal-infos, there's one mixin-related violation:

```
hint • The library 'package:protoc_plugin/testing/mixins.dart' is legacy, and should not be imported into a null safe library. • out/protos/mixins.pb.dart:12:8 • import_of_legacy_library_into_null_safe
```

Also slightly speeding up a build by removing make protos step from format stage: generated protos are not checked in and formatted anyway, but generating and checking format takes 3-4 minutes.

Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to github actions
2 participants