-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Travis to GitHub Actions #460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iinozemtsev
force-pushed
the
migrate_github_actions
branch
2 times, most recently
from
January 27, 2021 13:51
2663e42
to
a8189c8
Compare
Sample green run from my fork: https://github.com/iinozemtsev/protobuf/runs/1777185442 |
Closed
It seems that the last completed Travis build was 6 days ago, and travis-ci.org is going to be shut down anyway. As with travis, api_benchmark/query_benchmark have a single stage which generates protos checks format and runs analyzer. For protobuf and protoc_plugin I've split a single format_analyze_test stage into three separate stages for a better control of OSes and Dart SDK versions. `protobuf` tests run on windows, linux, and osx, but `protoc_plugin` tests run on linux only (we'd need a way to make `make protos` work on osx and windows to enable tests). Currently the pipeline takes about 16-17 minutes to run, mostly because `make protos` for protoc_plugin takes around 2 minutes and dartfmt check is slow (also around 2 minutes) for protoc_plugin and query_benchmark. If this is an issue, we can potentially speed it by 4 minutes by merging all protoc_plugin stages into one (as tests run on a single os anyway). Fixes google#459
iinozemtsev
force-pushed
the
migrate_github_actions
branch
from
January 27, 2021 14:49
a8189c8
to
afdd594
Compare
sigurdm
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
LGTM
iinozemtsev
added a commit
to iinozemtsev/protobuf
that referenced
this pull request
Jan 28, 2021
It seems that the last completed Travis build was 6 days ago, and travis-ci.org is going to be shut down anyway. As with travis, api_benchmark/query_benchmark have a single stage which generates protos checks format and runs analyzer. For protobuf and protoc_plugin I've split a single format_analyze_test stage into three separate stages for a better control of OSes and Dart SDK versions. `protobuf` tests run on windows, linux, and osx, but `protoc_plugin` tests run on linux only (we'd need a way to make `make protos` work on osx and windows to enable tests). Currently the pipeline takes about 16-17 minutes to run, mostly because `make protos` for protoc_plugin takes around 2 minutes and dartfmt check is slow (also around 2 minutes) for protoc_plugin and query_benchmark. If this is an issue, we can potentially speed it by 4 minutes by merging all protoc_plugin stages into one (as tests run on a single os anyway). Fixes google#459
iinozemtsev
added a commit
to iinozemtsev/protobuf
that referenced
this pull request
Jan 28, 2021
It seems that the last completed Travis build was 6 days ago, and travis-ci.org is going to be shut down anyway. As with travis, api_benchmark/query_benchmark have a single stage which generates protos checks format and runs analyzer. For protobuf and protoc_plugin I've split a single format_analyze_test stage into three separate stages for a better control of OSes and Dart SDK versions. `protobuf` tests run on windows, linux, and osx, but `protoc_plugin` tests run on linux only (we'd need a way to make `make protos` work on osx and windows to enable tests). Currently the pipeline takes about 16-17 minutes to run, mostly because `make protos` for protoc_plugin takes around 2 minutes and dartfmt check is slow (also around 2 minutes) for protoc_plugin and query_benchmark. If this is an issue, we can potentially speed it by 4 minutes by merging all protoc_plugin stages into one (as tests run on a single os anyway). Fixes google#459
iinozemtsev
added a commit
to iinozemtsev/protobuf
that referenced
this pull request
Jan 28, 2021
It seems that the last completed Travis build was 6 days ago, and travis-ci.org is going to be shut down anyway. As with travis, api_benchmark/query_benchmark have a single stage which generates protos checks format and runs analyzer. For protobuf and protoc_plugin I've split a single format_analyze_test stage into three separate stages for a better control of OSes and Dart SDK versions. `protobuf` tests run on windows, linux, and osx, but `protoc_plugin` tests run on linux only (we'd need a way to make `make protos` work on osx and windows to enable tests). Currently the pipeline takes about 16-17 minutes to run, mostly because `make protos` for protoc_plugin takes around 2 minutes and dartfmt check is slow (also around 2 minutes) for protoc_plugin and query_benchmark. If this is an issue, we can potentially speed it by 4 minutes by merging all protoc_plugin stages into one (as tests run on a single os anyway). Fixes google#459
iinozemtsev
added a commit
that referenced
this pull request
Jan 29, 2021
This brings the following changes from master branch: - Support optional proto3 fields (#444) - Fix handling of oneofs in dart proto3 json parsing. (#447) - Use @Dart = 2.7 in generated files (#455) - Migrate from Travis to GitHub Actions (#460) - Emit binary coded descriptors from dart protoc_plugin. (#406) Github Actions config modified to run only on dev sdk. Also modify analyzer flags to remove --fatal-infos, there's one mixin-related violation: ``` hint • The library 'package:protoc_plugin/testing/mixins.dart' is legacy, and should not be imported into a null safe library. • out/protos/mixins.pb.dart:12:8 • import_of_legacy_library_into_null_safe ``` Also slightly speeding up a build by removing make protos step from format stage: generated protos are not checked in and formatted anyway, but generating and checking format takes 3-4 minutes. Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the last completed Travis build was 6 days ago, and
travis-ci.org is going to be shut down anyway.
As with travis, api_benchmark/query_benchmark have a single stage
which generates protos checks format and runs analyzer.
For protobuf and protoc_plugin I've split a single format_analyze_test
stage into three separate stages for a better control of OSes and Dart
SDK versions.
protobuf
tests run on windows, linux, and osx, butprotoc_plugin
tests run on linux only (we'd need a way to make
make protos
work onosx and windows to enable tests).
Fixes #459