Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/pprof
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4bfdf5a
Choose a base ref
...
head repository: google/pprof
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 813a5fb
Choose a head ref
  • 8 commits
  • 11 files changed
  • 5 contributors

Commits on May 28, 2024

  1. fix: fix miss makezero bug (#867)

    Signed-off-by: alingse <alingse@foxmail.com>
    alingse authored May 28, 2024
    Configuration menu
    Copy the full SHA
    186aa03 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Bump actions/checkout from 4.1.6 to 4.1.7 (#873)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.1.7.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@a5ac7e5...692973e)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d3b898a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Bump codecov/codecov-action from 4.3.1 to 4.5.0 (#872)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.1 to 4.5.0.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@5ecb98a...e28ff12)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    dependabot[bot] and aalexand authored Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c177fd9 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Allow text selection in flamegraph view. (#874)

    Previously, the click handler would fire after some text was selected
    with the mouse. This would switch pivots and forget the selected text.
    
    We now switch the pivot only if the mouse did not move significantly
    between mouse-down and mouse-up.
    
    Fixes #870.
    ghemawat authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    27f5697 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Fix stacking order of profile details box. (#878)

    Previously the profile details box (displayed when clicking button
    at top-right of web view), would partially overlap flame graph text.
    Tweak z-index values to fix this problem.
    
    Also, colocate all z-index CSS entries to make the stacking order
    of different things easier to compare.
    ghemawat authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f6c9dda View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Bump actions/setup-go from 5.0.1 to 5.0.2 (#880)

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.1 to 5.0.2.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@cdcb360...0a12ed9)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 21, 2024
    Configuration menu
    Copy the full SHA
    7089f98 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Speed-up flame graph generation by skipping unneeded work. (#881)

    Previously, we used to call report.TextItems() during flame
    graph generation just so we could get a hand on the legend
    to print in the profile details box. All the work done by
    TextItems() to produce a trimmed graph was discarded.
    
    This change separates out the legend generation into a
    separate routine so that we can avoid doing the unnecessary
    work.
    
    Benchmark result:
    
    ```
    name      old time/op  new time/op  delta
    Flame-12   6.10s ± 3%   0.39s ± 4%  -93.59%  (p=0.000 n=10+10)
    ```
    ghemawat authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    304e4f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Use llvm-symbolizer's JSON output for symbolizing (#879)

    In some edge cases (e.g. injected JIT symbols), function names can have
    new lines. This breaks the llvm-symbolizer output parsing, and makes
    pprof hang.
    
    Conveniently, as of LLVM 13, llvm-symbolizer has a JSON output mode,
    which is robust against all kinds of weirdness like new lines. We can
    use this instead of the line-based parsing, and as a bonus we get much
    simpler handling of multiple frames in a stack, as the JSON output
    already returns these as an array.
    
    This also requires splitting the CODE and DATA processing into separate
    functions, since their JSON output is incompatible. For now, we keep the
    DATA output as before, a slightly hacky but functional concatenation of
    start + size, but this could be improved.
    
    Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
    LeszekSwirski and aalexand authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    813a5fb View commit details
    Browse the repository at this point in the history
Loading