Reorganize BluetoothSite logic #832

cco3 · 2016-09-20T19:17:29Z

Instead of:

Converting bytes to a string,
Adding to a string builder,
Converting back to bytes, and
Writing bytes to a file

we just write the bytes directly to a file.

hayesjordan

One nit otherwise LGTM

hayesjordan · 2016-09-20T19:24:36Z

android/PhysicalWeb/app/src/main/java/org/physical_web/physicalweb/BluetoothSite.java

+      try {
+        mHtml.close();
+      } catch (IOException e) {
+        Log.e(TAG, "Failed to write to file", e);


Failed to close file

Instead of: 1. Converting bytes to a string, 2. Adding to a string builder, 3. Converting back to bytes, and 4. Writing bytes to a file we just write the bytes directly to a file.

cco3 assigned hayesjordan Sep 20, 2016

hayesjordan reviewed Sep 20, 2016

View reviewed changes

Reorganize BluetoothSite logic

06ac0d1

Instead of: 1. Converting bytes to a string, 2. Adding to a string builder, 3. Converting back to bytes, and 4. Writing bytes to a file we just write the bytes directly to a file.

cco3 merged commit 8fbfb2c into google:master Sep 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize BluetoothSite logic #832

Reorganize BluetoothSite logic #832

cco3 commented Sep 20, 2016

hayesjordan left a comment

hayesjordan Sep 20, 2016

Reorganize BluetoothSite logic #832

Reorganize BluetoothSite logic #832

Conversation

cco3 commented Sep 20, 2016

hayesjordan left a comment

Choose a reason for hiding this comment

hayesjordan Sep 20, 2016

Choose a reason for hiding this comment