This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
[android] Require explicit call to DL favicon #456
Merged
+35
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is desirable for three reasons: 1. These are independent features of the PWS, the calls should be made distinct 2. The BeaconConfigFragment doesn't use the icon, so we shouldn't download it 3. When we start caching PWOs in the discovery service, we'll need to fetch icons if we already have the url metadata, but no icon.
|
Could we not include the favicon as part of the metadata returned from PWS (e.g. base64 encoded)? Then the PWS would only fetch the favicon string if the requester asked for it? |
|
A variant of this was discussed in #362. We'd like to be able to show the entry before necessarily having the favicon. Maybe we can get the PWS fast enough that it wouldn't matter though, dunno. |
|
LGTM |
cco3
added a commit
that referenced
this pull request
Jul 8, 2015
[android] Require explicit call to DL favicon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is desirable for three reasons:
distinct
download it
fetch icons if we already have the url metadata, but no icon.