Adds gcrypt to elliptic curve diff fuzzer #1696
Conversation
And adds corpus to the project
|
And here is another commit with another solution (looks better to me) |
There was a problem hiding this comment.
Yeah, don't have a better idea for a name conflict in a static build. Maybe @guidovranken has some
projects/ecc-diff-fuzzer/Dockerfile
Outdated
| RUN git clone --depth 1 https://github.com/catenacyber/elliptic-curve-differential-fuzzer.git ecfuzzer | ||
| RUN git clone --depth 1 https://github.com/ARMmbed/mbedtls.git mbedtls | ||
| RUN git clone --depth 1 https://github.com/ANSSI-FR/libecc.git libecc | ||
| RUN git clone --depth 1 https://github.com/openssl/openssl.git openssl | ||
| RUN curl -O https://www.gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.32.tar.bz2 |
There was a problem hiding this comment.
I used to think that we usually do either RUN wget or ADD, e.g.
oss-fuzz/projects/ffmpeg/Dockerfile
Line 31 in 01b5b6b
But probably this is fine too, since you used it in other Dockerfiles already
projects/ecc-diff-fuzzer/Dockerfile
Outdated
| @@ -16,10 +16,12 @@ | |||
|
|
|||
| FROM gcr.io/oss-fuzz-base/base-builder | |||
| MAINTAINER p.antoine@catenacyber.fr | |||
| RUN apt-get update && apt-get install -y make cmake | |||
| RUN apt-get update && apt-get install -y make cmake curl bzip2 autoconf automake libtool sed | |||
There was a problem hiding this comment.
Do you really need to install curl here? E.g. here it's not installed: https://github.com/google/oss-fuzz/blob/6c0458a14cea99e7de83fb0cde60eeb6635ce56e/projects/gnupg/Dockerfile
Nice, you can just exclude it! That's much better! Please remove the lines you've commented out. |
|
Here is the reviewed code |
|
Thanks! |
Also adds corpus to the project
Any better idea than my ugly hack as both gcrypt and openssl export a function named
poly1305_blocks?