GLib: more targets #1695
Merged
GLib: more targets #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dor1s
approved these changes
Aug 9, 2018
| @@ -0,0 +1,29 @@ | |||
| value="'" | |||
There was a problem hiding this comment.
It's not necessary to have a value= prefix, especially if it's the same for every element. The main purpose of these names to serve as comments for someone who would read the dictionary. Otherwise, just put elements in double quotes.
There was a problem hiding this comment.
I've been doing this habitually to have AFL compatibility, which I had assumed requires the name. I must've misread that when I read its docs originally. I just re-read the AFL docs and indeed it can be omitted.
tmatth
pushed a commit
to tmatth/oss-fuzz
that referenced
this pull request
Oct 22, 2018
* better seed corpus for fuzz_key * new target: fuzz_variant_text * new target: fuzz_dbus_message * get ninja from pip * remove target: fuzz_markup * new target: fuzz_variant_binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three targets, and removes one. The targets will move, but it'll take a while.