Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Do not force our LLVM revision. #1653

Merged
merged 1 commit into from
Jul 26, 2018
Merged

[infra] Do not force our LLVM revision. #1653

merged 1 commit into from
Jul 26, 2018

Conversation

Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Jul 25, 2018

The original issue should be fixed now as per #1560 (comment)

@Dor1s
Copy link
Contributor Author

Dor1s commented Jul 25, 2018

Running infra/base-images/all.sh locally to verify, though it doesn't look like it really builds all the images.

@Dor1s
Copy link
Contributor Author

Dor1s commented Jul 25, 2018

Everything seems to work fine. I've also tested this with the following script locally:

$ cat bootstrap.sh 
#!/bin/bash

if (( $# != 1 )); then
  echo "Usage: $0 <project_name>"
fi

project_name=$1

python infra/helper.py build_image --no-pull base-builder \
    && python infra/helper.py build_image --no-pull base-runner \
    && python infra/helper.py build_image --no-pull $project_name \
    && python infra/helper.py build_fuzzers --sanitizer=memory $project_name

I can land this tomorrow morning, kick off base-images build and keep an eye that everything is stable.

@Dor1s
Copy link
Contributor Author

Dor1s commented Jul 26, 2018

Giving this a try.

@Dor1s Dor1s merged commit 704da2d into master Jul 26, 2018
@Dor1s Dor1s deleted the not_force_llvm branch July 27, 2018 17:13
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
@Dor1s @tmatth
[infra] Do not force our LLVM revision. (google#1653)
1e9bcdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dor1s