This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
don't overwrite the ReplicaSet service label #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All pods were only declaring the 'cloud-sql-sidecar' service label, completely breaking service discovery
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 67.83% 67.90% +0.07%
==========================================
Files 54 54
Lines 4026 4026
==========================================
+ Hits 2731 2734 +3
+ Misses 893 891 -2
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
Mercurrent
approved these changes
Mar 2, 2020
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Mar 25, 2020
* master: (109 commits) Upgrade Prometheus (google#1500) Run `go build ./...` with github action (google#1446) Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492) Bump github.com/golang/mock from 1.4.1 to 1.4.2 Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1 Bump github.com/golang/protobuf from 1.3.3 to 1.3.5 Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0 New Design Doc (google#1469) Acknowledgements (google#1490) Use cases (google#1489) Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486) README.md # Related (google#1485) Explain authorized keys (google#1484) Use new prometheus sidecar deployment (google#1483) don't overwrite the ReplicaSet service label (google#1482) Update encrypted creds (google#1481) Pickup DB_HOST env variable (google#1480) Fix credential encryption (google#1479) Use Cloud MySQL in GKE (google#1473) Update client_secrets.json.enc (google#1478) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All pods were only declaring the 'cloud-sql-sidecar' service label, completely breaking service discovery