Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

New Design Doc #1469

Merged
merged 14 commits into from
Mar 9, 2020
Merged

New Design Doc #1469

merged 14 commits into from
Mar 9, 2020

Conversation

gdbelvin
Copy link
Contributor

Describe efficiency improvements and plan of work.

@gdbelvin gdbelvin requested a review from a team as a code owner February 19, 2020 17:49
@gdbelvin gdbelvin requested a review from RJPercival February 19, 2020 17:49
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #1469 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1469      +/-   ##
=========================================
- Coverage   68.13%   67.9%   -0.23%     
=========================================
  Files          54      54              
  Lines        4026    4026              
=========================================
- Hits         2743    2734       -9     
- Misses        887     891       +4     
- Partials      396     401       +5
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-5.72%) ⬇️
core/sequencer/server.go 73.94% <0%> (-0.98%) ⬇️
core/integration/client_tests.go 84.77% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb1289...569d2ef. Read the comment docs.

Copy link
Contributor

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
@gdbelvin gdbelvin requested review from pav-kv and removed request for RJPercival March 6, 2020 12:46
Copy link
Contributor

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nits.

docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
@gdbelvin gdbelvin changed the title Key Transparency 2.0 Design Doc Key Transparency v0.5 Design Doc Mar 9, 2020
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
docs/design2.md Outdated Show resolved Hide resolved
@gdbelvin gdbelvin assigned gdbelvin and unassigned paulmattei Mar 9, 2020
@gdbelvin gdbelvin changed the title Key Transparency v0.5 Design Doc Key Transparency New Design Doc Mar 9, 2020
@gdbelvin gdbelvin changed the title Key Transparency New Design Doc New Design Doc Mar 9, 2020
@gdbelvin gdbelvin requested a review from AlCutter March 9, 2020 13:34
@gdbelvin gdbelvin merged commit 5e555fd into google:master Mar 9, 2020
@gdbelvin gdbelvin deleted the design branch March 9, 2020 17:01
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 25, 2020
* master: (109 commits)
  Upgrade Prometheus (google#1500)
  Run `go build ./...` with github action (google#1446)
  Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492)
  Bump github.com/golang/mock from 1.4.1 to 1.4.2
  Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1
  Bump github.com/golang/protobuf from 1.3.3 to 1.3.5
  Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0
  New Design Doc (google#1469)
  Acknowledgements (google#1490)
  Use cases (google#1489)
  Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486)
  README.md # Related (google#1485)
  Explain authorized keys (google#1484)
  Use new prometheus sidecar deployment (google#1483)
  don't overwrite the ReplicaSet service label (google#1482)
  Update encrypted creds (google#1481)
  Pickup DB_HOST env variable (google#1480)
  Fix credential encryption (google#1479)
  Use Cloud MySQL in GKE (google#1473)
  Update client_secrets.json.enc (google#1478)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants