This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Use fake authentication in example #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
- Coverage 68.03% 67.93% -0.10%
==========================================
Files 54 54
Lines 4026 4026
==========================================
- Hits 2739 2735 -4
- Misses 889 891 +2
- Partials 398 400 +2
Continue to review full report at Codecov.
|
gdbelvin
force-pushed
the
fakeauth
branch
2 times, most recently
from
1b2a54c to
945ecfe
Compare
taknira
approved these changes
Feb 13, 2020
By using a fake authentication mechanism for the sandbox server we achieve two objectives: 1. We can avoid making the authentication Google specific. 2. We can avoid the need to embed OAuth client secrets in open source code. Client secrets are meant for particular compiled applications. Fixes google#1393 - Embed OAuth client ID
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a fake authentication mechanism for the sandbox server we
achieve two objectives:
code. Client secrets are meant for particular compiled applications.
Fixes #1393 - Embed OAuth client ID