This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Setup liveness and readiness k8 probes #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
- Coverage 66.49% 66.31% -0.18%
==========================================
Files 54 54
Lines 4026 4026
==========================================
- Hits 2677 2670 -7
- Misses 958 962 +4
- Partials 391 394 +3
Continue to review full report at Codecov.
|
gdbelvin
force-pushed
the
certmanager
branch
4 times, most recently
from
8dc13f4 to
7372cbd
Compare
gdbelvin
force-pushed
the
certmanager
branch
2 times, most recently
from
040cb10 to
d9570de
Compare
GCE Ingress Controllers require HTTP 200 to be served from '/' kubernetes/ingress-gce#241 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a precondition for using a GKE load ballancer, we must define readiness probes.
https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#limitations
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/