-
Notifications
You must be signed in to change notification settings - Fork 513
Allow Travis to stage release build #155
Conversation
@@ -1,8 +1,11 @@ | |||
language: java | |||
script: | |||
- ant -f ./client-libraries/java/rest-client/build.xml -lib ./client-libraries/java/rest-client/lib | |||
deploy | |||
stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we execute this only on tag?
before_install: | ||
- openssl aes-256-cbc -K $encrypted_8864fe5d711d_key -iv $encrypted_8864fe5d711d_iv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why in before_install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was automatically added there by travis, when the key was encrypted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move it to the script, to execute it only when we actually need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Remove branch restrictions
@@ -0,0 +1,16 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add some comments to explain the flow so that it's clear for everyone, then looks ready :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Allow Travis to stage release build
No description provided.