Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Allow Travis to stage release build #155

Merged
merged 6 commits into from
Jan 15, 2016
Merged

Allow Travis to stage release build #155

merged 6 commits into from
Jan 15, 2016

Conversation

kroikie
Copy link
Contributor

@kroikie kroikie commented Jan 14, 2016

No description provided.

@@ -1,8 +1,11 @@
language: java
script:
- ant -f ./client-libraries/java/rest-client/build.xml -lib ./client-libraries/java/rest-client/lib
deploy
stage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we execute this only on tag?

before_install:
- openssl aes-256-cbc -K $encrypted_8864fe5d711d_key -iv $encrypted_8864fe5d711d_iv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why in before_install?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was automatically added there by travis, when the key was encrypted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move it to the script, to execute it only when we actually need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,16 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add some comments to explain the flow so that it's clear for everyone, then looks ready :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

silvolu added a commit that referenced this pull request Jan 15, 2016
Allow Travis to stage release build
@silvolu silvolu merged commit 3bf2043 into master Jan 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants