Add @javax.annotation.Generated to generated flatbuffer Java types #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you run |
|
Done. Attached updated goldens. |
|
Thanks! |
|
As discussed on another thread, we'll need a way to use this without injection of these annotations as they add a dependency upon jsr250 on Android which some folks - like our project - do not want. @riklund any chance you could make this conditional ? |
aardappel
added a commit
that referenced
this pull request
Nov 2, 2018
#4986 missed part of the implementation. Change-Id: Ie41771eb018a550c289c77ebe9ef5c50d1ad6751
|
@stewartmiles @riklund |
shivendra14
pushed a commit
to shivendra14/flatbuffers
that referenced
this pull request
Nov 13, 2018
…oogle#4986) * Add @javax.annotation.Generated to generated flatbuffer Java types. * Updating test goldens.
shivendra14
pushed a commit
to shivendra14/flatbuffers
that referenced
this pull request
Nov 13, 2018
google#4986 missed part of the implementation. Change-Id: Ie41771eb018a550c289c77ebe9ef5c50d1ad6751
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
…oogle#4986) * Add @javax.annotation.Generated to generated flatbuffer Java types. * Updating test goldens.
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
google#4986 missed part of the implementation. Change-Id: Ie41771eb018a550c289c77ebe9ef5c50d1ad6751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow tooling to correctly infer that these types are generated.