Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++/Flexbuffers] Add missing const on Reference::As<> #4975

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

cor3ntin
Copy link
Contributor

@cor3ntin cor3ntin commented Oct 5, 2018

Reference::As<> was needlessly mutable which made them
less safe and harder to use

Reference::As<> was needlessly mutable wich made them
less safe and harder to use
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@cor3ntin
Copy link
Contributor Author

cor3ntin commented Oct 5, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@aardappel
Copy link
Collaborator

Thanks!

@aardappel aardappel merged commit 7c3c027 into google:master Oct 8, 2018
shivendra14 pushed a commit to shivendra14/flatbuffers that referenced this pull request Nov 13, 2018
Reference::As<> was needlessly mutable wich made them
less safe and harder to use
zchee pushed a commit to zchee/flatbuffers that referenced this pull request Feb 14, 2019
Reference::As<> was needlessly mutable wich made them
less safe and harder to use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants