Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/error-prone
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.34.0
Choose a base ref
...
head repository: google/error-prone
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.35.0
Choose a head ref
  • 8 commits
  • 21 files changed
  • 4 contributors

Commits on Oct 21, 2024

  1. GetSeconds to ToSeconds error prone 

    Per b/201676318, this converts `getSeconds` without corresponding `getNano` to `toSeconds.

The bulk of the codebase (java) has been migrated. Only a warning for now (though I supposed GoodTime will make it an error). Will suppress in 3P on a need-to-basis.

PiperOrigin-RevId: 688240816
    @java-team-github-bot
    java-team-github-bot authored and Error Prone Team committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    427b51d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. TimeUnitMismatch: consider trees like fooSeconds * 1000 to have uni… 

    …ts of `millis`.

PiperOrigin-RevId: 688500809
    @graememorgan
    graememorgan authored and Error Prone Team committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    60c5f76 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. TimeUnitMismatch: handle BinaryTrees. 

    PiperOrigin-RevId: 688939859
    @graememorgan
    graememorgan authored and Error Prone Team committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    99a0d9d View commit details
    Browse the repository at this point in the history

  2. Strip the quotation marks from the source code when reconstructing th… 

    …e literal.

My comment was a lie. This does obviously matter, because it's important to work out if the \s is at the end of the entire string.

PiperOrigin-RevId: 688949631
    @graememorgan
    graememorgan authored and Error Prone Team committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2ce9632 View commit details
    Browse the repository at this point in the history

  3. compileUnsafe -> compile for compile-time-constant expressions. 

    If they're safe, presumably they always will be.

PiperOrigin-RevId: 688957020
    @graememorgan
    graememorgan authored and Error Prone Team committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ec2983b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Remove DoNotUseRuleChain from JavaCodeClarity. 

    I summarised the thread and my views in b/287493298#comment7, so I won't repeat here, but do feel free to disagree.

PiperOrigin-RevId: 689316349
    @graememorgan
    graememorgan authored and Error Prone Team committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a931fa3 View commit details
    Browse the repository at this point in the history

  2. Add a repro test for broken behavior inlining the parameter value int… 

    …o the fully-qualified type package in the replacement.

PiperOrigin-RevId: 689427470
    @swegner
    swegner authored and Error Prone Team committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ed6b121 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Release Error Prone 2.35.0

    @cushon
    cushon committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ff3d929 View commit details
    Browse the repository at this point in the history
Loading