Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/error-prone
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.32.0
Choose a base ref
...
head repository: google/error-prone
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.33.0
Choose a head ref
  • 20 commits
  • 668 files changed
  • 8 contributors

Commits on Sep 11, 2024

  1. Don't allow @InlineMe on methods with params names matching `arg[0-…

    …9]+`.
    
    #inlineme
    
    PiperOrigin-RevId: 673502523
    kluever authored and Error Prone Team committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fcd3939 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Create a separate target for WellKnownThreadSafety and WellKnownMutab…

    …ility
    
    PiperOrigin-RevId: 673854014
    cushon authored and Error Prone Team committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1e6d3a5 View commit details
    Browse the repository at this point in the history
  2. Use text blocks for internal Error Prone test outputs

    The min JDK version for OSS is being updated to 17 as part of: #3803
    
    PiperOrigin-RevId: 673919944
    cushon authored and Error Prone Team committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c59fb34 View commit details
    Browse the repository at this point in the history
  3. Add a check to prevent record components of array type.

    The default `equals` and `hashCode` for a record with an array component will be inaccurate. Also, records should be immutable, and non-empty arrays are mutable.
    
    PiperOrigin-RevId: 674062270
    eamonnmcmanus authored and Error Prone Team committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    10c306a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Fix a bug when deleting the first member from an enum.

    PiperOrigin-RevId: 674306475
    graememorgan authored and Error Prone Team committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    af9fdd2 View commit details
    Browse the repository at this point in the history
  2. Use text blocks for more Error Prone test outputs

    I skipped reformatted these ones, because reformatting would cause some tests to fail, because of examples like
    
    ```
    // BUG: Diagnostic contains
    @OverRide void f() {}
    ```
    
    ```
    // BUG: Diagnostic contains
    @OverRide
    void f() {} // <- the diagnostic is actually on this line
    ```
    
    PiperOrigin-RevId: 674341306
    cushon authored and Error Prone Team committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    350815a View commit details
    Browse the repository at this point in the history
  3. Remove exemption for tests from EmptyCatch

    The style guide is being updated in unknown commit.
    
    Using `assertThrows` style assertions is now preferred over using try/catch statements for expected exception tests.
    
    Startblock:
      * unknown commit is submitted
    PiperOrigin-RevId: 674409794
    cushon authored and Error Prone Team committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1ff2959 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Fix the names of some Truth classes. (The AssertionCallback classes…

    … were deleted so long ago that we could probably remove the references outright, so let me know if you'd prefer that.)
    
    Startblock:
       unknown commit is submitted
    PiperOrigin-RevId: 675651056
    cpovirk authored and Error Prone Team committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cd0ef59 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. MemberName: check the casing of class names, too.

    I did a very small sample over com/google/a (I forced completion early), and the findings all look _correct_: unknown commit
    
    PiperOrigin-RevId: 675931096
    graememorgan authored and Error Prone Team committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    43ed6f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Add support for toSeconds in PreferJavaTimeOverload

    PiperOrigin-RevId: 676398528
    java-team-github-bot authored and Error Prone Team committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fa3c23d View commit details
    Browse the repository at this point in the history
  2. Support toSeconds in DurationToLongTimeUnit

    PiperOrigin-RevId: 676555168
    java-team-github-bot authored and Error Prone Team committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2c04ada View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Extend MissingOverride to require @OverRide on "an explicitly declare…

    …d accessor method for a record component"
    
    PiperOrigin-RevId: 677005515
    cushon authored and Error Prone Team committed Sep 20, 2024
    1 Configuration menu
    Copy the full SHA
    be99217 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Update protobuf version

    #4584
    
    PiperOrigin-RevId: 677823370
    cushon authored and Error Prone Team committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fb1a05b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix typos

    Fix typos in documentation, comments, etc.
    
    Fixes #4568
    
    COPYBARA_INTEGRATE_REVIEW=#4568 from algonell:master 086e9a6
    PiperOrigin-RevId: 678249177
    algonell authored and Error Prone Team committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f82fb66 View commit details
    Browse the repository at this point in the history
  2. Add some missing testdata/ prefixes.

    This supports removing the hack of checking both paths.
    
    PiperOrigin-RevId: 678280454
    graememorgan authored and Error Prone Team committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    50d0983 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Suggest Splitter.on(Pattern.compile(...)) instead of `Splitter.onPa…

    …ttern`
    
    onPattern is now deprecated.
    
    PiperOrigin-RevId: 678868087
    cushon authored and Error Prone Team committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    47dd2a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Avoid a possible IndexOutOfBoundsException in MemberName.

    Ordinarily we shouldn't see an empty class name but it appears that sometimes we do: []
    
    ```
    Sep 26, 2024 10:29:02 AM com.google.devtools.staticanalysis.pipeline.java.errorprone.ErrorProneFindingsJavacAnalyzer$1 handleError
    WARNING: crash in Error Prone analyzer MemberName [CONTEXT ratelimit_period="5 SECONDS" analyzer="JavaStyle" ]
    java.lang.StringIndexOutOfBoundsException: Index 0 out of bounds for length 0
    	at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
    	at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
    	at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
    	at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
    	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
    	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
    	at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
    	at java.base/java.lang.String.checkIndex(String.java:4881)
    	at java.base/java.lang.StringLatin1.charAt(StringLatin1.java:46)
    	at java.base/java.lang.String.charAt(String.java:1582)
    	at com.google.errorprone.bugpatterns.MemberName.isConformantUpperCamelName(MemberName.java:290)
    	at com.google.errorprone.bugpatterns.MemberName.matchClass(MemberName.java:111)
    	at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:460)
    	at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:558)
    	at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:157)
    ```
    PiperOrigin-RevId: 679249176
    eamonnmcmanus authored and Error Prone Team committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2b78c1f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Add a regression test for b/369862572

    PiperOrigin-RevId: 679372973
    cushon authored and Error Prone Team committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c885150 View commit details
    Browse the repository at this point in the history
  2. Remove out of place .. Previously, the error message was:

    ```
    Static variables should be named in UPPER_SNAKE_CASE if deeply immutable or lowerCamelCase if not., but autovarz_prefix is not; did you mean 'autovarzPrefix'?
    ```
    
    PiperOrigin-RevId: 679563848
    kluever authored and Error Prone Team committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f1f7955 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Release Error Prone 2.33.0

    cushon committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7a67f20 View commit details
    Browse the repository at this point in the history
Loading