-
Notifications
You must be signed in to change notification settings - Fork 746
Comparing changes
Open a pull request
base repository: google/error-prone
base: v2.32.0
head repository: google/error-prone
compare: v2.33.0
- 20 commits
- 668 files changed
- 8 contributors
Commits on Sep 11, 2024
-
Don't allow
@InlineMe
on methods with params names matching `arg[0-……9]+`. #inlineme PiperOrigin-RevId: 673502523
Configuration menu - View commit details
-
Copy full SHA for fcd3939 - Browse repository at this point
Copy the full SHA fcd3939View commit details
Commits on Sep 12, 2024
-
Create a separate target for WellKnownThreadSafety and WellKnownMutab…
…ility PiperOrigin-RevId: 673854014
Configuration menu - View commit details
-
Copy full SHA for 1e6d3a5 - Browse repository at this point
Copy the full SHA 1e6d3a5View commit details -
Use text blocks for internal Error Prone test outputs
The min JDK version for OSS is being updated to 17 as part of: #3803 PiperOrigin-RevId: 673919944
Configuration menu - View commit details
-
Copy full SHA for c59fb34 - Browse repository at this point
Copy the full SHA c59fb34View commit details -
Add a check to prevent record components of array type.
The default `equals` and `hashCode` for a record with an array component will be inaccurate. Also, records should be immutable, and non-empty arrays are mutable. PiperOrigin-RevId: 674062270
Configuration menu - View commit details
-
Copy full SHA for 10c306a - Browse repository at this point
Copy the full SHA 10c306aView commit details
Commits on Sep 13, 2024
-
Fix a bug when deleting the first member from an enum.
PiperOrigin-RevId: 674306475
Configuration menu - View commit details
-
Copy full SHA for af9fdd2 - Browse repository at this point
Copy the full SHA af9fdd2View commit details -
Use text blocks for more Error Prone test outputs
I skipped reformatted these ones, because reformatting would cause some tests to fail, because of examples like ``` // BUG: Diagnostic contains @OverRide void f() {} ``` ``` // BUG: Diagnostic contains @OverRide void f() {} // <- the diagnostic is actually on this line ``` PiperOrigin-RevId: 674341306
Configuration menu - View commit details
-
Copy full SHA for 350815a - Browse repository at this point
Copy the full SHA 350815aView commit details -
Remove exemption for tests from EmptyCatch
The style guide is being updated in unknown commit. Using `assertThrows` style assertions is now preferred over using try/catch statements for expected exception tests. Startblock: * unknown commit is submitted PiperOrigin-RevId: 674409794
Configuration menu - View commit details
-
Copy full SHA for 1ff2959 - Browse repository at this point
Copy the full SHA 1ff2959View commit details
Commits on Sep 17, 2024
-
Fix the names of some Truth classes. (The
AssertionCallback
classes…… were deleted so long ago that we could probably remove the references outright, so let me know if you'd prefer that.) Startblock: unknown commit is submitted PiperOrigin-RevId: 675651056
Configuration menu - View commit details
-
Copy full SHA for cd0ef59 - Browse repository at this point
Copy the full SHA cd0ef59View commit details
Commits on Sep 18, 2024
-
MemberName: check the casing of class names, too.
I did a very small sample over com/google/a (I forced completion early), and the findings all look _correct_: unknown commit PiperOrigin-RevId: 675931096
Configuration menu - View commit details
-
Copy full SHA for 43ed6f3 - Browse repository at this point
Copy the full SHA 43ed6f3View commit details
Commits on Sep 19, 2024
-
Add support for toSeconds in PreferJavaTimeOverload
PiperOrigin-RevId: 676398528
Configuration menu - View commit details
-
Copy full SHA for fa3c23d - Browse repository at this point
Copy the full SHA fa3c23dView commit details -
Support toSeconds in DurationToLongTimeUnit
PiperOrigin-RevId: 676555168
Configuration menu - View commit details
-
Copy full SHA for 2c04ada - Browse repository at this point
Copy the full SHA 2c04adaView commit details
Commits on Sep 20, 2024
-
Extend MissingOverride to require @OverRide on "an explicitly declare…
…d accessor method for a record component" PiperOrigin-RevId: 677005515
1Configuration menu - View commit details
-
Copy full SHA for be99217 - Browse repository at this point
Copy the full SHA be99217View commit details
Commits on Sep 23, 2024
-
#4584 PiperOrigin-RevId: 677823370
Configuration menu - View commit details
-
Copy full SHA for fb1a05b - Browse repository at this point
Copy the full SHA fb1a05bView commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f82fb66 - Browse repository at this point
Copy the full SHA f82fb66View commit details -
Add some missing testdata/ prefixes.
This supports removing the hack of checking both paths. PiperOrigin-RevId: 678280454
Configuration menu - View commit details
-
Copy full SHA for 50d0983 - Browse repository at this point
Copy the full SHA 50d0983View commit details
Commits on Sep 25, 2024
-
Suggest
Splitter.on(Pattern.compile(...))
instead of `Splitter.onPa……ttern` onPattern is now deprecated. PiperOrigin-RevId: 678868087
Configuration menu - View commit details
-
Copy full SHA for 47dd2a8 - Browse repository at this point
Copy the full SHA 47dd2a8View commit details
Commits on Sep 26, 2024
-
Avoid a possible
IndexOutOfBoundsException
inMemberName
.Ordinarily we shouldn't see an empty class name but it appears that sometimes we do: [] ``` Sep 26, 2024 10:29:02 AM com.google.devtools.staticanalysis.pipeline.java.errorprone.ErrorProneFindingsJavacAnalyzer$1 handleError WARNING: crash in Error Prone analyzer MemberName [CONTEXT ratelimit_period="5 SECONDS" analyzer="JavaStyle" ] java.lang.StringIndexOutOfBoundsException: Index 0 out of bounds for length 0 at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) at java.base/java.lang.String.checkIndex(String.java:4881) at java.base/java.lang.StringLatin1.charAt(StringLatin1.java:46) at java.base/java.lang.String.charAt(String.java:1582) at com.google.errorprone.bugpatterns.MemberName.isConformantUpperCamelName(MemberName.java:290) at com.google.errorprone.bugpatterns.MemberName.matchClass(MemberName.java:111) at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:460) at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:558) at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:157) ``` PiperOrigin-RevId: 679249176
Configuration menu - View commit details
-
Copy full SHA for 2b78c1f - Browse repository at this point
Copy the full SHA 2b78c1fView commit details
Commits on Sep 27, 2024
-
Add a regression test for b/369862572
PiperOrigin-RevId: 679372973
Configuration menu - View commit details
-
Copy full SHA for c885150 - Browse repository at this point
Copy the full SHA c885150View commit details -
Remove out of place
.
. Previously, the error message was:``` Static variables should be named in UPPER_SNAKE_CASE if deeply immutable or lowerCamelCase if not., but autovarz_prefix is not; did you mean 'autovarzPrefix'? ``` PiperOrigin-RevId: 679563848
Configuration menu - View commit details
-
Copy full SHA for f1f7955 - Browse repository at this point
Copy the full SHA f1f7955View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a67f20 - Browse repository at this point
Copy the full SHA 7a67f20View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.32.0...v2.33.0