Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/term
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.23.0
Choose a base ref
...
head repository: golang/term
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.25.0
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 24, 2024

  1. x/term: set missing VIRTUAL_TERMINAL_INPUT flag on Windows

    With this change the arrow keys work with Windows 11 Terminal
    
    After verifying https://github.com/containerd/console did work fine, unlike x/term, it's because they have:
    https://github.com/containerd/console/blob/v1.0.4/console_windows.go#L194
    using the same flag fixed x/term for my program
    
    Small e2e test reproducing the issue and showing it being fixed can be ran using
    
    go run fortio.org/terminal/example@v0.6.0  # has the fix (or @latest)
    
    go run fortio.org/terminal/example@v0.5.1  -history .history # does not have working arrow keys/this fix
    
    Fixes golang/go#68830
    
    Change-Id: If20addd054c76b889a52f933695467812be72306
    GitHub-Last-Rev: 68e3ca0
    GitHub-Pull-Request: #17
    Reviewed-on: https://go-review.googlesource.com/c/term/+/603960
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
    ldemailly authored and gopherbot committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    f867b76 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ia875ad082f993ce02f2cf97d6d3b318091360433
    Reviewed-on: https://go-review.googlesource.com/c/term/+/610637
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    gopherbot committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2f7b0dd View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I1fc21941bdc8066f3a8d24afdf16e6e10bceaf55
    Reviewed-on: https://go-review.googlesource.com/c/term/+/617955
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    gopherbot committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9d5441a View commit details
    Browse the repository at this point in the history
Loading