Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart-sass-embedded within the Hugo snap package is incomplete #10783

Closed
jmooring opened this issue Mar 4, 2023 · 1 comment · Fixed by #10784
Closed

dart-sass-embedded within the Hugo snap package is incomplete #10783

jmooring opened this issue Mar 4, 2023 · 1 comment · Fixed by #10784
Assignees
@jmooring
Labels
Bug Feature: Snap Package Outdated
Milestone
v0.111.2

Comments

@jmooring
Copy link
Member

jmooring commented Mar 4, 2023

The Sass team changed the Linux packaging with v1.58.0 and later:
sass/dart-sass-embedded#150

Now it's like the Windows and Mac packaging:

├── src/
│   ├── dart*
│   ├── dart-sass-embedded.snapshot*
│   └── LICENSE*
└── dart-sass-embedded*

The dart-sass-embedded script calls the dart executable which interacts with the dart-sass-embedded.snapshot.

So this bit needs to change:
https://github.com/gohugoio/hugo/blob/master/snap/snapcraft.yaml#L153-L157

cc @anthonyfok
jmooring added a commit to jmooring/hugo that referenced this issue Mar 4, 2023
@jmooring
snap: Fix dart-sass-embedded installation
e224a08 
Closes gohugoio#10783
@jmooring jmooring mentioned this issue Mar 4, 2023
Merged
@jmooring jmooring self-assigned this Mar 4, 2023
@bep bep added this to the v0.111.2 milestone Mar 4, 2023
@bep bep closed this as completed in #10784 Mar 4, 2023
bep pushed a commit that referenced this issue Mar 4, 2023
@jmooring @bep
snap: Fix dart-sass-embedded installation
a950950 
Closes #10783
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Bug Feature: Snap Package Outdated
Projects
None yet
Milestone
v0.111.2
Development

Successfully merging a pull request may close this issue.

snap: Fix dart-sass-embedded installation jmooring/hugo
2 participants
@jmooring @bep