Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not delete accessory relationship while still referenced #20360

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Apr 25, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#20377

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.33%. Comparing base (b7b8847) to head (065e70f).
Report is 170 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20360       +/-   ##
===========================================
- Coverage   67.56%   46.33%   -21.23%     
===========================================
  Files         991      247      -744     
  Lines      109181    13749    -95432     
  Branches     2719     2830      +111     
===========================================
- Hits        73768     6371    -67397     
+ Misses      31449     7054    -24395     
+ Partials     3964      324     -3640     
Flag Coverage Δ
unittests 46.33% <ø> (-21.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang enabled auto-merge (squash) April 30, 2024 01:09
@MinerYang MinerYang merged commit d01dfd4 into goharbor:main Apr 30, 2024
11 of 12 checks passed
njucjc added a commit to njucjc/harbor that referenced this pull request Jul 31, 2024
…o add_acr_as_proxy_cache

* 'add_acr_as_proxy_cache' of github.com:njucjc/harbor: (197 commits)
  fix: enale stop_scan for ci (goharbor#20378)
  fix update TRIVYVERSION=v0.50.4 & TRIVYADAPTERVERSION=v0.31.1 (goharbor#20390)
  Bump helm.sh/helm/v3 from 3.14.2 to 3.14.4 in /src (goharbor#20373)
  Bump github.com/go-asn1-ber/asn1-ber from 1.5.5 to 1.5.6 in /src (goharbor#20372)
  Bump github.com/gorilla/csrf from 1.6.2 to 1.7.2 in /src (goharbor#20376)
  Bump k8s.io/api from 0.29.3 to 0.30.0 in /src (goharbor#20375)
  Bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from 1.24.0 to 1.26.0 in /src (goharbor#20374)
  Rename harbor.sbom to sbom.harbor (goharbor#20359)
  do not delete accessory relationship while still referenced (goharbor#20360)
  Add scan type in webhook event (goharbor#20363)
  Fix UI sbom status not updated to grid item after job done (goharbor#20368)
  fix: update stop scan tc (goharbor#20369)
  Bump github.com/cenkalti/backoff/v4 from 4.2.1 to 4.3.0 in /src (goharbor#20316)
  Bump go.opentelemetry.io/otel/sdk from 1.24.0 to 1.26.0 in /src (goharbor#20370)
  Bump github.com/golang-migrate/migrate/v4 from 4.16.2 to 4.17.1 in /src (goharbor#20317)
  Bump golang.org/x/net from 0.22.0 to 0.24.0 in /src (goharbor#20318)
  Delete scan_report when accessory is removed (goharbor#20365)
  fix: update total permission count to 59 (goharbor#20352)
  Fix UI bugs (goharbor#20364)
  fix: add stop_scan_payload when call stop scan api (goharbor#20353)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants