Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] enhancement: add error log for create task #17403

Merged
merged 1 commit into from
Aug 16, 2022
Merged

[cherry-pick] enhancement: add error log for create task #17403

merged 1 commit into from
Aug 16, 2022

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 16, 2022

Signed-off-by: chlins chenyuzh@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins
enhancement: add error log for create task
3bd5c78 
Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins changed the title enhancement: add error log for create task [cherry-pick] enhancement: add error log for create task Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #17403 (3bd5c78) into release-2.5.0 (d21b88e) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.5.0   #17403      +/-   ##
=================================================
- Coverage          67.10%   67.07%   -0.04%     
=================================================
  Files                950      950              
  Lines              78633    78636       +3     
  Branches            2331     2331              
=================================================
- Hits               52769    52743      -26     
- Misses             22292    22324      +32     
+ Partials            3572     3569       -3
Flag Coverage Δ
unittests 67.07% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/task/execution.go 62.89% <50.00%> (-0.12%) ⬇️
src/pkg/task/task.go 67.32% <100.00%> (+0.32%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-47.83%) ⬇️
src/pkg/permission/evaluator/rbac/casbin_match.go 90.00% <0.00%> (-10.00%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.43% <0.00%> (-5.22%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 33.76% <0.00%> (-2.60%) ⬇️

wy65701436
wy65701436 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 77734ef into goharbor:release-2.5.0 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@stonezdj stonezdj stonezdj approved these changes

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

Labels
release-note/update Update or Fix target/2.5.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chlins @stonezdj @wy65701436