Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumpup golang to v1.17.13 #17309

Merged
merged 1 commit into from
Aug 3, 2022
Merged

bumpup golang to v1.17.13 #17309

merged 1 commit into from
Aug 3, 2022

Conversation

MinerYang
Copy link
Contributor

Signed-off-by: yminer yminer@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang
bumpup golang to v1.17.13
fec5d34 
Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang added the release-note/update Update or Fix label Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #17309 (fec5d34) into release-2.5.0 (7ad075f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.5.0   #17309      +/-   ##
=================================================
+ Coverage          67.08%   67.10%   +0.01%     
=================================================
  Files                950      950              
  Lines              78633    78633              
  Branches            2331     2331              
=================================================
+ Hits               52753    52768      +15     
+ Misses             22308    22294      -14     
+ Partials            3572     3571       -1
Flag Coverage Δ
unittests 67.10% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-nav/gc-page/gc/gc-history/gc-history.component.ts 50.94% <0.00%> (-9.44%) ⬇️
src/controller/event/topic.go 10.81% <0.00%> (+1.80%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 61.90% <0.00%> (+4.76%) ⬆️
...tegration/tag-retention/tag-retention.component.ts 35.65% <0.00%> (+5.21%) ⬆️

wy65701436
wy65701436 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit c8d467b into goharbor:release-2.5.0 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees
No one assigned
Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinerYang @wy65701436 @chlins