Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null pointer issue for creating reolication rule #17275

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Fix null pointer issue for creating reolication rule #17275

merged 1 commit into from
Jul 30, 2022

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 30, 2022 •
edited
Loading

  1. Fix null pointer issue for creating reolication rule
    Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix null pointer issue for creating reolication rule
2eb37f7 
Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing self-assigned this Jul 30, 2022
@AllForNothing AllForNothing added the release-note/update Update or Fix label Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022 •
edited
Loading

Codecov Report

Merging #17275 (2eb37f7) into release-2.5.0 (e2f5397) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.5.0   #17275      +/-   ##
=================================================
- Coverage          67.08%   67.05%   -0.04%     
=================================================
  Files                950      950              
  Lines              78632    78633       +1     
  Branches            2331     2331              
=================================================
- Hits               52754    52725      -29     
- Misses             22308    22336      +28     
- Partials            3570     3572       +2
Flag Coverage Δ
unittests 67.05% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ion/create-edit-rule/create-edit-rule.component.ts 35.25% <100.00%> (+0.20%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-47.83%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 52.38% <0.00%> (-9.53%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-7.21%) ⬇️
src/jobservice/sync/schedule.go 56.08% <0.00%> (-3.38%) ⬇️
...g-retention-tasks/tag-retention-tasks.component.ts 85.71% <0.00%> (+25.71%) ⬆️

chlins
chlins approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 97a7be6 into goharbor:release-2.5.0 Jul 30, 2022
@AllForNothing AllForNothing deleted the release-2.5.0 branch March 29, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

@chlins chlins chlins approved these changes

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees

@AllForNothing AllForNothing

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AllForNothing @chlins @YangJiao0817 @wy65701436