Add attribute admin username for authproxy #14583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14583 +/- ##
=======================================
Coverage 65.62% 65.63%
=======================================
Files 923 923
Lines 69402 69407 +5
Branches 2101 2101
=======================================
+ Hits 45547 45556 +9
+ Misses 19906 19899 -7
- Partials 3949 3952 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reasonerjt
force-pushed
the
authproxy-admin-username
branch
from
5764eb2 to
4f528fd
Compare
This commit adds the attribute "http_authproxy_admin_usernames", which is string that contains usernames separated by comma, when a user logs in and the username in the tokenreview status matches the setting of this attribute, the user will have administrator permission. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
authproxy-admin-username
branch
from
4f528fd to
ad8eee8
Compare
ywk253100
approved these changes
Apr 7, 2021
stonezdj
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the attribute "http_authproxy_admin_usernames", which
is string that contains usernames separated by comma, when a user logs
in and the username in the tokenreview status matches the setting of
this attribute, the user will have administrator permission.
Signed-off-by: Daniel Jiang jiangd@vmware.com