Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove limitation of artifact in the GC job #12595

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

wy65701436
Copy link
Contributor

To handle the orphan blobs that created in the quota exceeding case deletion, remove the limition of artifact remove.

Signed-off-by: wang yan wangyan@vmware.com

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #12595 into master will decrease coverage by 11.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12595       +/-   ##
===========================================
- Coverage   63.01%   51.60%   -11.41%     
===========================================
  Files         885      276      -609     
  Lines       54923    13391    -41532     
  Branches     1954     1954               
===========================================
- Hits        34609     6911    -27698     
+ Misses      16655     5823    -10832     
+ Partials     3659      657     -3002     
Flag Coverage Δ
#unittests 51.60% <ø> (-11.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ortal/src/lib/components/config/gc/gc.component.ts 54.92% <0.00%> (-2.82%) ⬇️
...m/goharbor/harbor/src/core/api/models/admin_job.go
...goharbor/harbor/src/server/middleware/blob/util.go
.../github.com/goharbor/harbor/src/common/api/base.go
...rc/github.com/goharbor/harbor/src/lib/log/level.go
...c/github.com/goharbor/harbor/src/core/api/label.go
...b.com/goharbor/harbor/src/common/dao/repository.go
...arbor/harbor/src/server/v2.0/handler/repository.go
...goharbor/harbor/src/jobservice/common/rds/utils.go
...m/goharbor/harbor/src/controller/artifact/model.go
... and 601 more

To handle the orphan blobs that created in the quota exceeding case deletion, remove the limition of artifact remove.

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 merged commit cf46775 into goharbor:master Jul 29, 2020
tedgxt pushed a commit to tedgxt/harbor that referenced this pull request Aug 11, 2020
To handle the orphan blobs that created in the quota exceeding case deletion, remove the limition of artifact remove.

Signed-off-by: wang yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants