-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GDScript warning system to use @warning_ignore
#8250
Update GDScript warning system to use @warning_ignore
#8250
Conversation
b0047dc
to
469d836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, please resolve merge conflicts so we can merge this. See PR workflow for instructions 🙂
PS: In the future, please use the Default theme for screenshots (the one with a dark blue background instead of a gray background). This is to ensure visual consistency across screenshots in the official documentation.
d7cf2d0
to
e1db20a
Compare
@rarysson Could I bother you to re-take those screenshots with the default theme, and also to convert the PNG files to WebP while you're at it (we're in the process of moving the docs repository over to WebP, see image creation guidelines)? Otherwise this looks good to go for me, thanks for contributing! And if you don't have time for further work that is fine too, just let me know :) |
bee8852
to
dcfd5fb
Compare
dcfd5fb
to
49133c0
Compare
@mhilbrunner done! |
@rarysson Amazing first contribution, helping out with outdated images is always welcome as its so much work :) Thanks for taking the time to contribute and making those changes too. 🎉Merged. |
Fix #8145.
Update the GDScript warning system doc to use annotation to ignore a warning instead of a comment.