Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GDScript warning system to use @warning_ignore #8250

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

rarysson
Copy link
Contributor

@rarysson rarysson commented Oct 15, 2023

Fix #8145.

Update the GDScript warning system doc to use annotation to ignore a warning instead of a comment.

@rarysson rarysson force-pushed the update-warning-system branch 3 times, most recently from b0047dc to 469d836 Compare October 16, 2023 00:08
@Calinou Calinou added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 labels Nov 9, 2023
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please resolve merge conflicts so we can merge this. See PR workflow for instructions 🙂

PS: In the future, please use the Default theme for screenshots (the one with a dark blue background instead of a gray background). This is to ensure visual consistency across screenshots in the official documentation.

@rarysson rarysson force-pushed the update-warning-system branch 4 times, most recently from d7cf2d0 to e1db20a Compare November 10, 2023 03:32
@mhilbrunner
Copy link
Member

@rarysson Could I bother you to re-take those screenshots with the default theme, and also to convert the PNG files to WebP while you're at it (we're in the process of moving the docs repository over to WebP, see image creation guidelines)?

Otherwise this looks good to go for me, thanks for contributing! And if you don't have time for further work that is fine too, just let me know :)

@rarysson rarysson force-pushed the update-warning-system branch 2 times, most recently from bee8852 to dcfd5fb Compare November 10, 2023 14:33
@rarysson rarysson force-pushed the update-warning-system branch from dcfd5fb to 49133c0 Compare November 10, 2023 14:33
@rarysson
Copy link
Contributor Author

@mhilbrunner done!

@mhilbrunner mhilbrunner merged commit 85fc55a into godotengine:master Nov 10, 2023
1 check passed
@mhilbrunner
Copy link
Member

mhilbrunner commented Nov 10, 2023

@rarysson Amazing first contribution, helping out with outdated images is always welcome as its so much work :) Thanks for taking the time to contribute and making those changes too. 🎉Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning System Documentation needs updating
3 participants