Corrections to "Advanced Vector Math" #589
Conversation
typos and code correction
| @@ -169,7 +169,7 @@ Some examples of planes | |||
| Here is a simple example of what planes are useful for. Imagine you have | |||
| a `convex <http://www.mathsisfun.com/definitions/convex.html>`__ | |||
| polygon. For example, a rectangle, a trapezoid, a triangle, or just any | |||
There was a problem hiding this comment.
I think I would change this to be something like "...polygon, such as a triangle, rectangle, or trapezoid."
There was a problem hiding this comment.
I tried to be as non-intrusive as I could. I only edited the typos and mistakes. I'm very inexperienced so I probably have to be very cautious.
There was a problem hiding this comment.
I understand. The majority of my own contributions to this repository are non-intrusive spelling and grammar corrections!
I should have added this comment on the line below to be more clear: As you are changing this sentence already, I think it would work just as well if you simplified it further and merged it into the previous sentence. No need to worry about it getting accepted, as I already have approved the change.
EDIT: If you still don't feel comfortable making the change, the pull request is acceptable as it is. Just let us know.
There was a problem hiding this comment.
@amirea Please let us know whether or not you are interested in making any further refinements to this sentence. If not, this is ready to merge.
There was a problem hiding this comment.
It's good. And also if it's OK with you, please merge it.
|
This whole article is need of a major rewrite. Ref #532 |
|
@cbscribe That's fine, this contribution can still be accepted despite the rest of the article needing more work. |
|
Sure - just trying to encourage some deeper revisions ;) |
|
I looked for a way to edit the commit title but I couldn't find any. At least I'll know for next time. |
| # or alternatively | ||
| # var normal = Vector2(-dvec.y,dev.x) | ||
| # var normal = Vector2(-dvec.y,dvec.x) |
There was a problem hiding this comment.
While you're at it, add a space after the , for readability - here and above.
|
As far as I know, there is no way to edit commits on GitHub. It is not a problem, I can clean it up a bit before merging. |
|
The only way is another commit that will overwrite the previous. Now I'm working at that file + another ones. I probably was not inspire to just pr a single file in the first place. I should have work on a larger part of the doc. and only after that make the request. |
|
Making PRs that only include small changes to one file is completely acceptable, in my opinion. You can just keep making PRs whenever you feel like contributing. |
Corrections to "Advanced Vector Math"
|
I made the history prettier (one commit with a more descriptive message), so your contribution is in c27d32e. Thanks for your efforts! Edit: To clarify, you still get the credit as the author. |
|
Thank you for the kindness and support shown. I'll double my efforts in the future. |
Fixed typos and code bugs. Please double check as I'm 98% sure about it.