Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and incorrect or incomplete instructions #578

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

mattsp1290
Copy link
Contributor

No description provided.

gives the best fit, so next to "Shape" in the Inspector, click
Finally, add a :ref:`CollisionShape2D <class_CollisionShape2D>` as a child
of the ``Player``. This will determine the player's "hitbox", or the
bounds of its collision area. Rename the node to ``Collision``. For this character, a ``CapsuleShape2D``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the collision shape node is not really necessary, since we're not accessing it directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed by changing the screenshot (with the node renamed) to match the text. I will upload a new image. Please remove this change and I can merge the rest of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbscribe I have made this change. One line 351 of your first game, was that the correct syntax for referencing menus? On 442 of the same file, was that the correct name for that menu? I did not see any hover text for it, but that seemed contextually accurate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Snapping Options" button does have hover text, but it's new since this tutorial was written, so yes your change is now correct.

@cbscribe cbscribe merged commit 79b6aa5 into godotengine:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants