Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more errors #3401

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Conversation

YeldhamDev
Copy link
Member

Only thing I couldn't fix was the multimesh_set_as_bulk_array() reference, as I have no clue to what substitute it for.

@YeldhamDev YeldhamDev added the bug label Apr 17, 2020
@clayjohn
Copy link
Member

clayjohn commented Apr 17, 2020

Looks like it is now multimesh_set_buffer

Funny you did this! I started going through to fix errors this morning, but then realized we hadn't moved over all the class renames, so I decided to wait.

Would also be worth doing a ctrl+f for "Spatial Material" and "SpatialMaterial"

@YeldhamDev
Copy link
Member Author

@clayjohn This PR is just to fix actual formatting errors, adapting the docs to the new names is out-of-scope and should be its own PR.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YeldhamDev Sounds good. We can just do it later.

@akien-mga akien-mga merged commit e900de1 into godotengine:master Apr 18, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Yeah I haven't synced the classref for 4.0 as it's still very WIP, and it will prompt lots of changes to the docs that will make merging 3.2-relevant changes on 3.2 harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants