Use new full-page search UI from upstream RTD #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://readthedocs-sphinx-search.readthedocs.io, can also be tested on https://docs.readthedocs.io.
|
Probably needs dark theme adjustments, right? |
That's likely yeah. I'll merge so that we can test, and then we'll have to see if we can adjust the theme via our CSS overrides or if we need to actual vendor the extension to edit its source. |
|
It doesn't think to work yet on https://docs.godotengine.org/en/latest/, not sure if I missed anything. |
|
Don't you need to enable it?
|
|
Ah, I forgot to commit my |
akien-mga
added a commit
that referenced
this pull request
Mar 16, 2020
I forgot to push this change in the previous PR...
|
Should be fixed with c85c68e. |
|
Yep, seems to be working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://readthedocs-sphinx-search.readthedocs.io,
can also be tested on https://docs.readthedocs.io.
It only works on RTD so I haven't confirmed yet that it's working, the build resulting from merging this PR will be the test in production.