Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Hack adding --quit-after 100 to ensure extension_list.cfg gets generated" #1304

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Revert "Hack adding --quit-after 100 to ensure extension_list.cfg gets generated" #1304

merged 1 commit into from
Nov 10, 2023

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Nov 7, 2023

Reverts PR #1299

I want to see if this passes CI, then I'll take it out of draft.

@dsnopek dsnopek added the bug This has been identified as a bug label Nov 7, 2023
@dsnopek dsnopek requested a review from a team as a code owner November 7, 2023 21:53
@dsnopek dsnopek marked this pull request as draft November 7, 2023 21:53
@dsnopek dsnopek mentioned this pull request Nov 7, 2023
Merged
@dsnopek
Copy link
Collaborator Author

dsnopek commented Nov 7, 2023

Tests are passing! Taking out of draft

@dsnopek dsnopek marked this pull request as ready for review November 7, 2023 23:39
@akien-mga akien-mga merged commit 73757e3 into godotengine:master Nov 10, 2023
12 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsnopek @akien-mga