Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignoring venv in .gitignore #1301

Merged
merged 1 commit into from
Nov 9, 2023
Merged

ignoring venv in .gitignore #1301

merged 1 commit into from
Nov 9, 2023

Conversation

brno32
Copy link
Contributor

@brno32 brno32 commented Nov 5, 2023 •
edited
Loading

Since python is a dependency for building this code, it seems like a requirements.txt file should be part of the repo.

venv folders should also be in the .gitignore, akin to godotengine/godot@a6fda19

@brno32 brno32 requested a review from a team as a code owner November 5, 2023 16:53
@brno32 brno32 requested a review from a team as a code owner November 5, 2023 21:03
@dsnopek
Copy link
Collaborator

dsnopek commented Nov 6, 2023

Thanks!

I'm not sure about adding the requirements.txt - the main Godot repo also uses scons and doesn't include one. However, adding the the venv folders to the .gitignore to match what's in Godot sounds good to me.

@brno32 brno32 changed the title add requirements.txt and scons to dependencies ignoring venv in .gitignore Nov 6, 2023
@brno32
Copy link
Contributor Author

brno32 commented Nov 6, 2023

Thanks!

I'm not sure about adding the requirements.txt - the main Godot repo also uses scons and doesn't include one. However, adding the the venv folders to the .gitignore to match what's in Godot sounds good to me.

fair enough. I'll ask about using a requirements.txt in the godot repo so that it's clear what version of scons should be used.

I've updated this to only include my changes to the .gitignore for now

dsnopek
dsnopek approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.1 labels Nov 8, 2023
@dsnopek dsnopek added this to the 4.x milestone Nov 8, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Nov 9, 2023
@akien-mga akien-mga merged commit cc89bd2 into godotengine:master Nov 9, 2023
12 checks passed
@akien-mga
Copy link
Member

Thanks!

@dsnopek
Copy link
Collaborator

dsnopek commented Nov 10, 2023

Cherry-picked for 4.1 in PR #1306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddy-exe paddy-exe paddy-exe approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@brno32 @dsnopek @akien-mga @paddy-exe