-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing int→Variant conversions #1298
Conversation
70e6512
to
553fa08
Compare
Also added |
Thanks! This makes sense to me
GDExtension does support iOS builds, however, we don't ever define |
This will need a rebase after PR #1299 in order for tests to pass |
f0e4ddb
to
45298ca
Compare
Rebased the repo & updated the iOS build system to use |
Thanks! This looks good to me, but I'm also not very experienced with iOS. @bruvzg Do the iOS bits make sense to you? |
45298ca
to
bcac96c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me :-)
Cherry-picking to 4.1 in #1373 |
Implements
int8_t
,uint8_t
,int16_t
, anduint16_t
operations/constructors for Variant. This matches the implementation of the main repo (albeit using thestdint.h
names), and allows binding methods that use these types as parameters/returns