Automatically remove editor plugins when deinitializing GDExtension #1138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, developers need to manually remove editor plugins when their GDExtension is deinitialized, for example:
This isn't ideal, because:
EditorPlugins::remove_by_type<T>()
in Godot, so this is inconsistent with how Godot modules workThis PR has godot-cpp automatically remove any editor plugins when the GDExtension is being uninitialized.
Since this functionality was added for Godot 4.1, I think it would be good to get this PR in for 4.1 as well, so that developers don't start using a pattern that is unnecessary.
This comes from a suggestion from @Zylann on #1114 (comment)