Goblint's stdout/stderr redirected into output #8 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added All debug info that Goblint dumps is now redirected so that it is shown in the Output console in vscode. This is done with zt-exec, which has a method to redirect stdout and stderr to System.err. As the default runCommand method from MagpieBridge's ToolAnalysis class is no longer used due to the need to use zt-exec's ProcessExecutor instead of ProcessBuilder, GoblintAnalysis now implements ServerAnalysis interface instead of ToolAnalysis. Logging support was added with Log4j. Logs are shown in the Output console as well. The default level is info, but debug level can be used for development. For using debug level, log4j2.xml file must be edited. On the info level, the command Goblint was executed with is logged as well as some additional info (e.g. magpie server started). Some additional exception handling was added to prevent reading from a JSON file after the Goblint run fails, as there were exceptions when another file's analysis result was tried to be shown in a different file.
vesalvojdani
requested changes
Nov 17, 2021
vesalvojdani
approved these changes
Nov 17, 2021
4 tasks
karoliineh
pushed a commit
that referenced
this pull request
Jun 26, 2024
Refactor: improve maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goblint's stdout/stderr redirected into output #8 and logging support added
stdoutandstderrtoSystem.err.MagpieBridge'sToolAnalysisclass is no longer used due to the need to usezt-exec'sProcessExecutorinstead ofProcessBuilder, GoblintAnalysis now implementsServerAnalysisinterface instead ofToolAnalysis.log4j2.xmlfile must be edited.