-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the crash handler work on wine properly #1636
Conversation
Saving a tspack should now also work correctly on wine. |
ccc1e8b
to
a303cea
Compare
Tested OK on Windows. Linux test failing for now on stock Steam Deck + XLCore config. Current state is an apparent bug in Wine >= 8.5 that causes a crash reading PDBs leading to no VEH screen and the game instead hanging indefinitely. Tested OK with Wine 7.10.r3. Crash screen on Steam Deck takes about 30 seconds to pop, though this is likely environmental. Works fine in Gamescope, we have plenty of room to add a "generate tspack" button should we want it, though it does clip if anyone makes the mistake of opening the stacktrace log screen. Restart tested OK. Crash files are generated in |
Yeah the pdb issue on Wine >= 8.5 is a bit annoying and not something I initially tested for. |
Windows tested OK. Wine 7.10 tests OK, VEH pops up. Stock wine does not pop VEH (as expected); Wine's own exception handler pops instead. (Is this intended?) |
This should greatly help debugging native crashes (plus the managed stack, if useful, will also be logged) |
Also of note: on Windows, forcefully killing I think this is fine, so +1ing. |
This includes a few fixes to make injector arg passing properly work (and passes in everything XL does).
VEH has been fully functional on wine 7+ from what I could gather (and the original Dalamud crash was into a VEH semi-stub on wine 6), however it currently chokes on
std::chrono::zoned_time
, which is only really used for debug logging and so it should be fine.In any case will try to get it fixed upstream.