Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

fix time issues and add some tests for time #604

Merged
merged 5 commits into from
Jun 2, 2017
Merged

fix time issues and add some tests for time #604

merged 5 commits into from
Jun 2, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 1, 2017

No description provided.

@lunny lunny added this to the 0.7 milestone Jun 1, 2017
@codecov-io
Copy link

codecov-io commented Jun 2, 2017 •
edited
Loading

Codecov Report

Merging #604 into master will decrease coverage by 0.01%.
The diff coverage is 52%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #604      +/-   ##
=========================================
- Coverage   49.71%   49.7%   -0.02%     
=========================================
  Files          30      31       +1     
  Lines        6933    6929       -4     
=========================================
- Hits         3447    3444       -3     
  Misses       3025    3025              
+ Partials      461     460       -1
Impacted Files Coverage Δ
helpers.go 53.72% <ø> (-1.55%) ⬇️
session_update.go 50.42% <0%> (-1.99%) ⬇️
statement.go 61.37% <0%> (ø) ⬆️
dialect_mssql.go 0% <0%> (ø) ⬆️
session_insert.go 57.34% <100%> (ø) ⬆️
xorm.go 69.49% <100%> (+2.21%) ⬆️
helpler_time.go 100% <100%> (ø)
session_convert.go 21.69% <36.36%> (-0.44%) ⬇️
session_raw.go 60.31% <59.63%> (-0.94%) ⬇️
session.go 50.2% <60%> (-0.81%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c179e4...7788ac7. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Jun 2, 2017

will fix #310 #324 #556 #585 and drop #581

@lunny
Copy link
Member Author

lunny commented Jun 2, 2017

and #134

@lunny lunny merged commit 942887d into master Jun 2, 2017
This was referenced Jun 2, 2017
Closed
Closed
@lunny lunny deleted the lunny/fix_time_issues branch August 5, 2017 05:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug kind/refactor
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@lunny @codecov-io