Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Make json handler as interface #1248

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Make json handler as interface #1248

merged 1 commit into from
Mar 29, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 13, 2019 •
edited
Loading

should resolve #1218

@lunny lunny added this to the 0.8 milestone Mar 13, 2019
@lunny lunny mentioned this pull request Mar 13, 2019
Closed
@codecov-io
Copy link

codecov-io commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #1248 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1248      +/-   ##
=========================================
+ Coverage   57.37%   57.4%   +0.03%     
=========================================
  Files          43      44       +1     
  Lines        7807    7811       +4     
=========================================
+ Hits         4479    4484       +5     
  Misses       2772    2772              
+ Partials      556     555       -1
Impacted Files Coverage Δ
json.go 100% <100%> (ø)
session.go 58.49% <11.11%> (ø) ⬆️
engine_cond.go 56.29% <25%> (ø) ⬆️
session_convert.go 22.29% <30%> (ø) ⬆️
statement.go 68.3% <33.33%> (ø) ⬆️
xorm.go 69.69% <0%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2d47e...4fc085a. Read the comment docs.

@lunny lunny force-pushed the lunny/json_interface branch from 880a5cb to 4fc085a Compare March 13, 2019 14:00
@lunny lunny merged commit 5ef12ea into master Mar 29, 2019
HaochangZhang
HaochangZhang reviewed Apr 10, 2019
View reviewed changes
Copy link

@HaochangZhang HaochangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I think the type of DefaultJSONHandler should be JSONInterface instead of StdJSON.

@lunny lunny deleted the lunny/json_interface branch April 11, 2019 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HaochangZhang HaochangZhang HaochangZhang left review comments

@BetaCat0 BetaCat0 BetaCat0 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

want support jsoniter to en/decode json
4 participants
@lunny @codecov-io @BetaCat0 @HaochangZhang