chore(stages): add orchestration docs under usage section #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wass3rw3rk
previously approved these changes
Apr 11, 2023
Co-authored-by: David May <49894298+wass3rw3rk@users.noreply.github.com>
cognifloyd
requested changes
Apr 13, 2023
| - echo $VELA_REPO_FULL_NAME | ||
| ``` | ||
|
|
||
| So in fact, in this scenario, the `run-first` stage and the `y-stage` begin simultaneously, even though `y-stage` "needed" `compile-time-ruleset-stage` which "needed" `run-first` in the original pipeline. |
There was a problem hiding this comment.
Wow! Yes this needed to be documented. That is surprising.
…la/docs into improve-staging-orchestration-docs
cognifloyd
reviewed
Apr 13, 2023
cognifloyd
approved these changes
Apr 13, 2023
timhuynh94
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be worth while to add more examples / explanations for the various orchestration tools given to users when it comes to
stages, such asneedsandindependent. Further, I think outlining the behavior of stage pipelines in the context of ruleset pruning can be very helpful.Let me know if you think this content belongs elsewhere in the docs or if you have any edits / comments!