Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(installation): worker registration docs #354

Merged
merged 7 commits into from
Apr 25, 2023
Merged

chore(installation): worker registration docs #354

merged 7 commits into from
Apr 25, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Apr 7, 2023

cognifloyd
cognifloyd previously approved these changes Apr 9, 2023
View reviewed changes
@ecrupper ecrupper marked this pull request as ready for review April 25, 2023 16:04
@ecrupper ecrupper requested a review from a team as a code owner April 25, 2023 16:04
wass3rw3rk
wass3rw3rk previously approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not crucial, but i noticed a lot of manual line breaks. we really don't need that, so the text can flow naturally depending on resolution, otherwise you get funky breaks when you resize browser.

@ecrupper ecrupper removed the next label Apr 25, 2023
@ecrupper ecrupper merged commit d89ba33 into main Apr 25, 2023
@ecrupper ecrupper deleted the worker-registration-docs branch April 25, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk left review comments

@cognifloyd cognifloyd cognifloyd left review comments

Assignees
No one assigned
Labels
0.19.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ecrupper @cognifloyd @timhuynh94 @plyr4 @wass3rw3rk