🤖

Hello @perriea,

Nice to meet you! I'm Dosu, a bot here to assist you with bugs, answer your questions, and guide you on your journey to becoming a contributor. While we wait for a human maintainer to join us, feel free to ask me anything about the Kratos repository. I'm here to help!

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

SGTM, can I entrust you with completing this task?

can I entrust you with completing this task?

Yes, but, I need to explore how add protovalidate in the core and if it's complicated or not :

• PGV generate Go/Java/C++/... code to verify inputs,
• protovalidate is based on CEL (Common Expression Language), no code is generated and use his runtime : [BUG] No-op validation functions being generated bufbuild/protovalidate#47 (comment)

Finaly, It's simple (after one call HTTP) :

2023-11-13T23:57:00.408+0100 [ERROR] app: args="filters:{values:\"1\"}  sort:{argument:Ticker}  pagination:{items:1  page:-1}" caller=recovery/recovery.go:59 code=400 component=http kind=server latency=0.001073208 operation=/instruments.v1.Instruments/Search reason=VALIDATOR
  stack=
  | error: code = 400 reason = VALIDATOR message = validation error:
  |  - pagination.page: value must be greater than or equal to 1 [int32.gte] metadata = map[] cause = validation error:
  |  - pagination.page: value must be greater than or equal to 1 [int32.gte]

• On tests, obviously, it's a fail, I don't know how to repair because now, it's not a classic struct but a protoreflect.ProtoMessage,
• protovalidate-go require google.golang.org/grpc v1.57.0, today google.golang.org/grpc v1.56.1 (shared dependencies between all packages),
• I will do more tests tomorrow.

Hi, @perriea,

I'm helping the Kratos team manage our backlog and am marking this issue as stale. From what I understand, you requested replacing PGV with protovalidate in the Kratos repository, layout, and examples, along with updating the documentation and providing a migration protocol. There were updates on your progress, including exploring the process of adding protovalidate in the core and encountering challenges with testing and dependencies.

Could you please confirm if this issue is still relevant to the latest version of the Kratos repository? If it is, please let the Kratos team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your understanding and cooperation.

I

Hi, @perriea,

I'm helping the Kratos team manage our backlog and am marking this issue as stale. From what I understand, you requested replacing PGV with protovalidate in the Kratos repository, layout, and examples, along with updating the documentation and providing a migration protocol. There were updates on your progress, including exploring the process of adding protovalidate in the core and encountering challenges with testing and dependencies.

Could you please confirm if this issue is still relevant to the latest version of the Kratos repository? If it is, please let the Kratos team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your understanding and cooperation.

I

Pull request ready but not reviewed

Hi, @perriea,

I'm helping the Kratos team manage their backlog and am marking this issue as stale. It looks like you opened this issue to request replacing PGV with protovalidate due to maintenance concerns and the announcement of protovalidate in April 2023. The migration involves updating the repository, layout, examples, and documentation, and providing a protocol for the migration process. There have been updates on the progress, including exploring the process of adding protovalidate in the core and encountering challenges with testing and dependencies. A pull request is ready but not yet reviewed.

Could you please let us know if this issue is still relevant to the latest version of the Kratos repository? If it is, please comment on the issue to let the Kratos team know. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you!