fix(transport/grpc): remove autoprefixing logic #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the autoprefixing of "pb" to service names, to allow for grpc services created without a package prefix. Fixes go-kit#447. BREAKING CHANGE: Existing users of the grpc client transport who were relying on the autoprefixing of the "pb" package name must manually update their clients to add it. No change is required if a package name was already being manually prefixed.
terinjokes
force-pushed
the
terin/remove-grpc-client-prefixing
branch
from
27bbb35 to
76e141a
Compare
|
thanks! |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
…t-prefixing fix(transport/grpc): remove autoprefixing logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the autoprefixing of "pb" to service names, to allow for
grpc services created without a package prefix.
Fixes #447.
BREAKING CHANGE: Existing users of the grpc client transport who were
relying on the autoprefixing of the "pb" package name must manually
update their clients to add it. No change is required if a package name
was already being manually prefixed.