Fix rvl auth bearer token branch #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here apk-token was, and fix some related tab/space issues
catskul
force-pushed
the
fix-rvl-auth-bearer-token
branch
from
4aaa502 to
b3723c7
Compare
|
Wow, that is deeper than the original |
Yeah, it turns out most of the places we were comparing to "api-token" we meant any type of token token. One example was that despite having |
|
One thing that could be taken a step further is that the password store could be made to differentiate between |
mikepea
approved these changes
Nov 28, 2021
There was a problem hiding this comment.
I don't have a local JIRA instance to test this against, but the code appears solid and it matches to the documentation at https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html#UsingPersonalAccessTokens-UsingPATs
Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to @rvl's branch which adds bearer tokens: #438