Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-co-op/gocron
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.35.2
Choose a base ref
...
head repository: go-co-op/gocron
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.35.3
Choose a head ref
  • 6 commits
  • 10 files changed
  • 5 contributors

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    cda6e1c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. fix: set multi-weekdays bug about issue-590 (#592)

    Co-authored-by: jerry.wang <jerry.wang>
    Co-authored-by: John Roesler <johnrroesler@gmail.com>
    XiXiangFiles and JohnRoesler authored Oct 28, 2023
    Configuration menu
    Copy the full SHA
    5f95210 View commit details
    Browse the repository at this point in the history
  2. Update FUNDING.yml

    JohnRoesler authored Oct 28, 2023
    Configuration menu
    Copy the full SHA
    93a954c View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Avoid allocations with (*regexp.Regexp).MatchString (#602)

    We should use `(*regexp.Regexp).MatchString` instead of
    `(*regexp.Regexp).Match([]byte(...))` when matching string to avoid
    unnecessary `[]byte` conversions and reduce allocations.
    
    Example benchmark:
    
    func BenchmarkMatch(b *testing.B) {
    	for i := 0; i < b.N; i++ {
    		if match := timeWithSeconds.Match([]byte("06:18:01")); !match {
    			b.Fail()
    		}
    	}
    }
    
    func BenchmarkMatchString(b *testing.B) {
    	for i := 0; i < b.N; i++ {
    		if match := timeWithSeconds.MatchString("06:18:01"); !match {
    			b.Fail()
    		}
    	}
    }
    
    goos: linux
    goarch: amd64
    pkg: github.com/go-co-op/gocron
    cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
    BenchmarkMatch-16          	 7213512	       223.8 ns/op	       8 B/op	       1 allocs/op
    BenchmarkMatchString-16    	 8484169	       145.8 ns/op	       0 B/op	       0 allocs/op
    PASS
    ok  	github.com/go-co-op/gocron	4.114s
    
    Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
    Juneezee authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    12cfd7a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    912b4a7 View commit details
    Browse the repository at this point in the history
  2. fix(scheduler): ensure negative intervals given to Every return an …

    …immediate error #600 (#603)
    
    * fix(scheduler): ensure negative intervals given to `Every` return an immediate error #600
    
    * Update Every func doc
    
    * fix error check in tests
    
    Co-authored-by: John Roesler <johnrroesler@gmail.com>
    
    * Apply suggestions from code review
    
    * Apply suggestions from code review
    
    * Update scheduler_test.go
    
    ---------
    
    Co-authored-by: John Roesler <johnrroesler@gmail.com>
    husam-e and JohnRoesler authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    9993f76 View commit details
    Browse the repository at this point in the history
Loading