feat: 🎸 export conversations into csv #142
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OdapX
force-pushed
the
feat/89-export-conversations
branch
from
72b4d8a to
7a0c6cb
Compare
OdapX
force-pushed
the
feat/89-export-conversations
branch
from
7a0c6cb to
c9e2733
Compare
OdapX
force-pushed
the
feat/89-export-conversations
branch
from
c9e2733 to
41c1f91
Compare
OdapX
force-pushed
the
feat/89-export-conversations
branch
from
41c1f91 to
7ccc728
Compare
pages/api/conversations/export.ts
Outdated
| req: AppNextApiRequest, | ||
| res: NextApiResponse | ||
| ) { | ||
| const conversationIds = req.body.ids as string[]; |
There was a problem hiding this comment.
It would be better to fetch all conversations of the currently authenticated user instead of passing an array of IDs. Plus with the array of ids, you would need to check that the user is authorized to access the conversation. Also if conversation IDs are passed to the front, only conversation-loaded (there is pagination implemented on this page) will be exported.
So I think we should just fetch all conversations of the current user. Ok for you?
There was a problem hiding this comment.
you're absolutely right on it
pages/api/conversations/export.ts
Outdated
| return zip.generateAsync({ type: "nodebuffer" }); | ||
| } | ||
|
|
||
| export default async function wrapper( |
There was a problem hiding this comment.
Can you replace this code with "export default handler;"
This wrapper is only necessary for endpoints available through our official Chaindesk API (to authorize external domain to call the endpoint).
This endpoint is not meant to be available through the Chaindesk API
pages/logs/index.tsx
Outdated
| @@ -34,6 +35,7 @@ import relativeDate from '@app/utils/relative-date'; | |||
| import { fetcher } from '@app/utils/swr-fetcher'; | |||
| import { withAuth } from '@app/utils/withAuth'; | |||
|
|
|||
| import { ConversationExportAlert } from '../../components/ConversationExportAlert'; | |||
There was a problem hiding this comment.
Can you use the path alias please (@app/utils/ etc..) ?
pages/api/conversations/export.ts
Outdated
| methods: ["POST", "HEAD"], | ||
| }); | ||
|
|
||
| async function exportConversation( |
pages/api/conversations/export.ts
Outdated
| }) | ||
| ); | ||
|
|
||
| async function exportConversations(conversations: ConversationWithMessages[]) { |
There was a problem hiding this comment.
rename to zipConversations (or something similar. Just name after what the function is meant to do)
pages/api/conversations/export.ts
Outdated
| const zip = new JSZip(); | ||
|
|
||
| const header = [ | ||
| "conversation__id", |
There was a problem hiding this comment.
Is the extra underscore necessary?
OdapX
force-pushed
the
feat/89-export-conversations
branch
from
7ccc728 to
752872c
Compare
OdapX
force-pushed
the
feat/89-export-conversations
branch
from
752872c to
e8f92e1
Compare
gmpetrov
force-pushed
the
feat/89-export-conversations
branch
from
e8f92e1 to
63eeb85
Compare
gmpetrov
force-pushed
the
feat/89-export-conversations
branch
from
63eeb85 to
4193f3c
Compare
feat: 🎸 export conversations into csv ✅ Closes: #89
gmpetrov
force-pushed
the
feat/89-export-conversations
branch
from
4193f3c to
3eea4cb
Compare
BREAKING CHANGE: 🧨 n
export conversations into csv files and download a zip file.
✅ Closes: #89