Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance) Multiple performance improvements and other fixes #28

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

gmbeard
Copy link
Owner

@gmbeard gmbeard commented Dec 9, 2023

Performance:

  • Adds dedicated thread for dequeueing and writing encoded packets
  • Use native (BGRA) colourspace for NVFBC capture Using the native colourspace means NVFBC doesn't have to perform any conversion. In theory, this will improve capture performance
  • Allow NvFBC to wait up to a maximum time for a new frame

Fixes:

  • Adds eventfd for cancelling contexts without timers Contexts without timers require this to be cancellable with request_stop().
  • Fixes memory leak in h/w frame context initialization

Other:

  • Adds metrics for video and audio encoding frame times
  • Adds performance report generator script
  • Allows NvFBC adjusted FPS to be enabled/disabled with ENV var SHADOW_CAST_STRICT_FPS. Defaults to 1.
  • Add FAQ

Performance:
- Adds dedicated thread for dequeueing and writing encoded packets
- Use native (BGRA) colourspace for NVFBC capture
  Using the native colourspace means NVFBC doesn't have to perform any
  conversion. In theory, this will improve capture performance
- Allow NvFBC to wait up to a maximum time for a new frame

Fixes:
- Adds eventfd for cancelling contexts without timers
  Contexts without timers require this to be cancellable with
  `request_stop()`.
- Fixes memory leak in h/w frame context initialization

Other:
- Adds metrics for video and audio encoding frame times
- Adds performance report generator script
- Allows NvFBC adjusted FPS to be enabled/disabled with ENV var
  `SHADOW_CAST_STRICT_FPS`. Defaults to `1`.
- Add FAQ
@gmbeard gmbeard self-assigned this Dec 9, 2023
@gmbeard gmbeard merged commit 67b6057 into main Dec 9, 2023
@gmbeard gmbeard deleted the feature/performance-improvements branch December 9, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant