-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enum StrSlice
under enum Evaluated
#999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrdltl
changed the title
Add enum StrSlice under enum Evaluated
Add enum Nov 12, 2022
StrSlice
under enum Evaluated
ever0de
reviewed
Nov 12, 2022
Pull Request Test Coverage Report for Build 4096482561
💛 - Coveralls |
zmrdltl
force-pushed
the
feature-evaluated
branch
from
January 23, 2023 07:08
82a5c34
to
08abc77
Compare
zmrdltl
commented
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed to write part 2 test.
panarch
reviewed
Feb 3, 2023
panarch
reviewed
Feb 3, 2023
ever0de
reviewed
Feb 3, 2023
Signed-off-by: MeenSeek Kim <meenseek5929@naver.com>
panarch
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! New big improvement comes into the project.
Thanks a lot 👍 👍 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
after #966
If a function that handles a string is chained and executed on the query builder, the string is copied every time by the Clone trait. This overhead is solved by always having a sliced enum with a value.
Implementation plan
If a variant called source holds the source of the string, and the string function is called continuously after that, the range is updated every time.
Tasks
modify string function structure for StrSlice
tests