-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main to release-v0.13.1 #992
Merged
panarch
merged 25 commits into
gluesql:release-v0.13.1
from
devgony:release-v0.13.1-to-main
Nov 8, 2022
Merged
Merge main to release-v0.13.1 #992
panarch
merged 25 commits into
gluesql:release-v0.13.1
from
devgony:release-v0.13.1-to-main
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Cargo.toml, README.md & package.json versions to 0.13.0
Change ExprNode to ExprNode<'a>. Update ExprNode::Expr to contain Cow<..>. Apply corresponding changes - mainly updating select nodes to have lifetimes
Set "PRIMARY" as a reserved keyword for index names. Block use of "PRIMARY" name in create or drop index queries.
enum Evaluated does not need to use Cow for enum Value from: pub enum Evaluated<'a> { Literal(Literal<'a>), Value(Cow<'a, Value>), } to: pub enum Evaluated<'a> { Literal(Literal<'a>), Value(Value), }
change return type Result<Value> to Result<Evaluated> All existing functions operating in evaluate are evaluated by enum Value without having to have an intermediate value, Evaluated. However, if it is used in a future query builder, if it is a chained structure in a function such as a substring that should always hold an intermediate value, an overhead may occur by repeating the clone. In this case, it can be solved by string slicing to keep the intermediate value. Modify the return values for this structure.
…esql#967) Update ExprNode & ExprList to accept both String and &str to build ExprNode. Update ExprList to accept both owned vector and borrowed slice.
Current pkg example uses SledStorage and it leaves data/doc-db data after runs. This can cause some issues when we do change to the codes which requires migration. Rather than adding file removal code to lib example, it would be good to simply have minimal example using MemoryStorage. MemoryStorage does not leave any of persistent data so there cannot be any migration issue.
…luesql#924) Add `Dictionary::GLUE_OBJECTS` which provides table and index metadata in the entire database. Support Dictionary::`GLUE_OBJECTS` to serve OBJECT_TYPE, CREATED metadata Add `created` datetime field to `Schema` and `SchemaIndex` Change SHOW INDEXES query to use `GLUE_INDEXES`.
Some users need to be able to use the `module_or_path` argument of the function `init` that `wasm-pack` generates. In my case, it enables loading the WASM module in an environment that is neither the browser nor node (edge). This modification can fix WASM loading issues for other users too.
Add CONCAT_WS function in AST CONCAT_WS(separator,str1,str2,...) CONCAT_WS function does skip any NULL values after the separator argument.
Remove `ast::ColumnOptionDef` and make it only use `ast::ColumnOption`
ast::ColumnDef is in the same crate so it is not necessary to expand using extra trait. Replace ColumnDefExt to use adding direct impl to ast::ColumnDef.
Print results of all Statements including DDL and TCL It would be helpful to watch the progress of executing lots of sqls in file.
panarch
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
pre-merging main to release-v0.13.1
Todo