Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support printing results of all Statements including DDL and TCL #984

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Support printing results of all Statements including DDL and TCL #984

merged 1 commit into from
Nov 4, 2022

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented Nov 4, 2022

Goal

Print results of all Statements including DDL and TCL

  • It would be helpful to watch the progress of executing lots of sqls in file.
gluesql> CREATE TABLE User (id INT);
Table created

gluesql> ALTER TABLE User ADD COLUMN name TEXT NULL;
Table altered

gluesql> CREATE INDEX User_id ON User (id);
Index created

gluesql> DROP INDEX User.User_id;
Index dropped

gluesql> DROP TABLE User;
Table dropped

gluesql> BEGIN;
Transaction started

gluesql> COMMIT;
Commit completed

gluesql> BEGIN;
Transaction started

gluesql> ROLLBACK;
Rollback completed

Todo

  • cover all payloads on cli::print

@devgony devgony added the enhancement New feature or request label Nov 4, 2022
@devgony devgony requested review from panarch and ever0de November 4, 2022 07:13
@devgony devgony self-assigned this Nov 4, 2022
@devgony devgony marked this pull request as ready for review November 4, 2022 07:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3391916692

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 98.408%
Files with Coverage Reduction New Missed Lines %
core/src/translate/function.rs 1 99.69%
Totals Coverage Status
Change from base Build 3355209055: 0.05%
Covered Lines: 39322
Relevant Lines: 39958
💛 - Coveralls

panarch
panarch approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Thanks for the contribution 👍

@panarch panarch merged commit d3d2a9d into gluesql:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@panarch panarch panarch approved these changes

@24seconds 24seconds Awaiting requested review from 24seconds

@MRGRAVITY817 MRGRAVITY817 Awaiting requested review from MRGRAVITY817

Assignees

@devgony devgony

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devgony @coveralls @panarch @ever0de