Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose wasm-pack's init function argument to users #971

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

arbfay
Copy link
Contributor

@arbfay arbfay commented Oct 28, 2022

Some users need to be able to use the module_or_path argument of the function init that wasm-pack generates. In my case, it enables loading the WASM module in an environment that is neither the browser nor node (edge). This modification can fix WASM loading issues for other users too.

Some users need to be able to use the `module_or_path` argument of the function `init` that `wasm-pack` generates. In my case, it enables loading the WASM module in an environment that is neither the browser nor node (edge).
This modification can fix WASM loading issues for other users too.
@panarch panarch added the improvement Improvements for existing features label Oct 29, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3347158989

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 97.857%

Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 34 81.82%
Totals Coverage Status
Change from base Build 3338482795: -0.04%
Covered Lines: 38275
Relevant Lines: 39113

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks that I also now got to know how wasm-pack init works.
Thanks a lot!

@panarch panarch merged commit 07eb030 into gluesql:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants